Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(allocator): remove default features from hashbrown #8619

Merged
merged 1 commit into from
Jan 20, 2025
Merged

chore(allocator): remove default features from hashbrown #8619

merged 1 commit into from
Jan 20, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 20, 2025

No description provided.

@Boshen Boshen requested a review from overlookmotel January 20, 2025 12:56
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 20, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jan 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8619 will not alter performance

Comparing 01-20-chore_allocator_remove_default_features_from_hashbrown (c9f3c5f) with main (6801c81)

Summary

✅ 32 untouched benchmarks

overlookmotel
overlookmotel approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ha great! I hadn't noticed there are features we can disable.

Pushed another commit to remove the raw-entry feature too. We don't use it.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 20, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Jan 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 20, 11:18 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 20, 11:18 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 20, 11:23 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 01-20-chore_allocator_remove_default_features_from_hashbrown branch from 1b2ae86 to c9f3c5f Compare January 20, 2025 16:18
@graphite-app graphite-app bot merged commit c9f3c5f into main Jan 20, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 01-20-chore_allocator_remove_default_features_from_hashbrown branch January 20, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boshen @overlookmotel