Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks/prettier): Visualize test details #8634

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(tasks/prettier): Visualize test details #8634

merged 1 commit into from
Jan 21, 2025

Conversation

leaysgur
Copy link
Contributor

For example, if there are 3 tests in 1 spec and all of them fail:

  • πŸ’₯πŸ’₯πŸ’₯

After some implementation, if 1 test passes:

  • πŸ’₯πŸ’₯✨

However, in this case, the coverage as number does not change.

This PR visualizes these details for better mental well-being. πŸ˜ƒ
(But in practice, specs are so detailed, there is not much opportunity for this...)

Copy link

graphite-app bot commented Jan 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-prettier Area - Prettier C-enhancement Category - New feature or request labels Jan 21, 2025
@Boshen
Copy link
Member

Boshen commented Jan 21, 2025

neat!

@Boshen Boshen merged commit 891a9c2 into main Jan 21, 2025
15 checks passed
@Boshen Boshen deleted the p/tasks-detail branch January 21, 2025 09:01
Boshen pushed a commit that referenced this pull request Jan 30, 2025
…ormat (#8788)

Previously, #8634 visualized each spec result, but this was not enough.

If the implementation has been updated but the spec still fails, there
is no way to know if there is an improvement or not.

This time, finally, all progress is visualized! 🀩 


![image](https://github.com/user-attachments/assets/df5b4658-450a-4b0c-8348-ffc9b977c50c)

e.g. here `arrow_function_expression` is mostly passing, except for
comment handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-prettier Area - Prettier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants