Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transformer): add legacy decorator tests that come from TypeScript #8692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 24, 2025

Part of #8614

All tests copy over from https://github.com/microsoft/TypeScript/blob/8da951cbb629b648753454872df4e1754982aef1/tests/cases/conformance/decorators/class, in addition, several multi-file tests were also adjusted.

The output is generated by

transpileModule(
  source,
  {
    compilerOptions: {
      target: 'esnext',
      experimentalDecorators: true,
      noEmitHelpers: true
    },
  }
)

and replace all __decorate with babelHelpers.decorate and __param with babelHelpers.decorateParam

Copy link
Member Author

Dunqing commented Jan 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 24, 2025
@Dunqing Dunqing force-pushed the 01-24-chore_transformer_add_legacy_decorator_tests_that_come_from_typescript branch from 3dd1f4d to 0abe2b8 Compare January 24, 2025 13:39
@Boshen
Copy link
Member

Boshen commented Jan 24, 2025

When ever you decide to merge.

@Dunqing Dunqing force-pushed the 01-24-chore_transformer_add_legacy_decorator_tests_that_come_from_typescript branch from 0abe2b8 to 30c5764 Compare January 26, 2025 11:28
@Dunqing Dunqing force-pushed the 01-24-chore_transformer_add_legacy_decorator_tests_that_come_from_typescript branch from 30c5764 to 05c7d6a Compare January 27, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants