show correct auto complete value for nargs option in combination with flag option #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaipraneeth
force-pushed
the
bugfix/OptionsAutoCompletion
branch
from
f68161b to
c9e86aa
Compare
msaipraneeth
force-pushed
the
bugfix/OptionsAutoCompletion
branch
from
c9e86aa to
71cec9c
Compare
msaipraneeth
force-pushed
the
bugfix/OptionsAutoCompletion
branch
from
71cec9c to
952899e
Compare
|
@AndreasBackx Have we selected the correct bash branch for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves an issue in the autocompletion logic for options with nargs > 1 when combined with boolean options. Previously, autocompletion would suggest incorrect values, leading to confusion and an inconsistent user experience.
fixes #2813
should fail without the change.