Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite first half of options docs #2825

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Rewrite first half of options docs #2825

merged 3 commits into from
Jan 12, 2025

Conversation

Rowlando13
Copy link
Collaborator

@Rowlando13 Rowlando13 commented Dec 17, 2024 •
edited
Loading

  • Sections move to new separate file are not edited.
  • Sections on options at or below prompting not edited.

@Rowlando13 Rowlando13 marked this pull request as draft December 17, 2024 06:07
@Rowlando13 Rowlando13 changed the base branch from stable to main December 26, 2024 08:28
@Rowlando13 Rowlando13 changed the title Add parameter-types section. Make heading nicer. Rewrite first half of options docs Dec 28, 2024
@Rowlando13 Rowlando13 marked this pull request as ready for review January 2, 2025 04:51
@Rowlando13 Rowlando13 added the docs label Jan 2, 2025
AndreasBackx
AndreasBackx approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@AndreasBackx AndreasBackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous! Thanks for making this so easy to review.

Nit: maybe include a bit more in the PR summary.

Rowlando13 and others added 3 commits January 12, 2025 15:11
@Rowlando13 @AndreasBackx
Rewrite options docs.
62f4312 
- split out sections for shortcut decorators and parameter types.
- Rewrite first half of options docs.
@Rowlando13 @AndreasBackx
Fix typos in options docs.
c08019c
@AndreasBackx
Remove duplicate options
f4161f1
@AndreasBackx AndreasBackx merged commit 82089af into pallets:main Jan 12, 2025
2 checks passed
@Rowlando13 Rowlando13 deleted the rewrite_options branch January 13, 2025 05:45
@Rowlando13 Rowlando13 mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBackx AndreasBackx AndreasBackx approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rowlando13 @AndreasBackx