Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameter guard #80

Merged
merged 4 commits into from
Jan 6, 2025
Merged

feat: parameter guard #80

merged 4 commits into from
Jan 6, 2025

Conversation

tdeshong
Copy link
Contributor

@tdeshong tdeshong commented Jan 6, 2025

What's New?

  • Adds parameter guards for all Auth and User operations to simplify input checks that can be done before making a network request

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tdeshong tdeshong marked this pull request as ready for review January 6, 2025 18:20
@tdeshong tdeshong requested a review from ctran88 January 6, 2025 18:20
@tdeshong tdeshong merged commit ad7239f into main Jan 6, 2025
4 checks passed
@tdeshong tdeshong deleted the feat-param-guard branch January 6, 2025 18:32
@ctran88 ctran88 mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants