Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move operations to nested Auth and User structs #29

Closed
wants to merge 2 commits into from

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 17, 2024

What's New?

  • moves auth operations under a nested Auth struct
  • moves user operations under a nested User struct
  • keeps the set_server_url func to maintain tests until they are moved to the e2e suite
  • removes the get_app func since it doesn't really serve much purpose except for a test of the sdk without inducing any side effects

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 closed this Dec 17, 2024
@ctran88 ctran88 deleted the PSG-5450-remove-deploy-workflow branch December 17, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant