-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: move operations to nested Auth and User structs #30
Conversation
@@ -62,5 +62,7 @@ pub mod models; | |||
#[rustfmt::skip] | |||
pub mod openapi; | |||
|
|||
pub mod auth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this would also expose the auth and user structs to the developer
self.user.configuration.base_path = format!("{}/v1/apps/{}", server_url, self.app_id); | ||
self.auth.configuration.base_path = format!("{}/v1/apps/{}", server_url, self.app_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
necessary to mock the server calls in the unit tests. this can be removed once the tests are moved to the e2e suite
The repo's README will also need updates to reference the nested structure. |
7661fde
to
a1540af
Compare
There's a usage example in lib.rs that will need to be updated: Line 14 in c8f0840
EDIT: Looks like this also applies to the various methods that were moved around, like this example: Line 70 in a1540af
|
ac297a2
to
943b1e9
Compare
What's New?
Auth
structUser
structset_server_url
func to maintain tests until they are moved to the e2e suiteget_app
func since it doesn't really serve much purpose except for a test of the sdk without inducing any side effectsScreenshots (if appropriate):
Type of change
Checklist:
Additional context