This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Added improved error handling and Open API generated code #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(PSG-3976): otp & ml auth methods refactor * refactor(PSG-3976): refactored passkey methods * refactor(PSG-3976): remove olde MagicLink struct * refactor(PSG-3976): removed unused api client code
* refactor(PSG-3976): otp & ml auth methods refactor * refactor(PSG-3976): refactored passkey methods * refactor(PSG-3976): remove olde MagicLink struct * refactor(PSG-3976): removed unused api client code * refactor: removed `PassageAPIClient` * refactor: cleaned up unused models
* refactor(PSG-3976): otp & ml auth methods refactor * refactor(PSG-3976): refactored passkey methods * refactor(PSG-3976): remove olde MagicLink struct * refactor(PSG-3976): removed unused api client code * refactor: removed `PassageAPIClient` * refactor: cleaned up unused models * refactor: removed PassageSettings class * refactor: update app info tests * refactor: updated get user tests * refactor: updated otp tests * refactor: updated magic link tests * refactor: updated change contact tests * refactor: updated current user tests * refactor: update device tests * refactor: updated session tests * refactor: updated social auth tests * refactor: removed outdated unit tests * refactor: removed unnecessary static test data * refactor: misc test cleanup * Update Sources/Passage/PassageAuth.swift Signed-off-by: Ricky Padilla <[email protected]> --------- Signed-off-by: Ricky Padilla <[email protected]>
SinaSeylani
reviewed
Jun 18, 2024
SinaSeylani
previously approved these changes
Jun 18, 2024
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Improved error enums
When calling a
PassageAuthmethod, developers can now catch and handle more specific error cases.OpenAPI generated code
We replaced manually written networking code with auto-generated code using Passage’s OpenAPI auth-api specification.
Added new instance methods
The methods below were available only as static methods, and are now available as instance methods as well.
appInfo()newRegisterMagicLink()newLoginMagicLink()newRegisterOneTimePasscode()newLoginOneTimePasscode()getUser()Errorenums in favor of more exhaustivePassageErrorenums.Contributor notes
CONTRIBUTING.mdto begin documenting how to contribute to this repo.CONTRIBUTING.mdto learn how to run code generator.Other related changes
Rewrote integration tests
Previously, integration tests tested the
PasageAPIClientclass directly. This class has been removed. Now the tests are written against instances ofPassageAuthinstead.