Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add e2e test to on-pr workflow #222

Merged
merged 2 commits into from
Jan 22, 2025
Merged

ci: add e2e test to on-pr workflow #222

merged 2 commits into from
Jan 22, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 17, 2025

What's New?

  • runs the e2e test suite on pull request
  • a team member is expected to at least have write permissions on this repo. successful permissions check and e2e test run here
  • an OS contributor is expected to only have read permissions on this repo. successful permissions check here

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 marked this pull request as ready for review January 17, 2025 20:01
@ctran88 ctran88 force-pushed the PSG-5721-sdk-test-node branch from 17bc70d to cad57ab Compare January 21, 2025 22:01
@ctran88 ctran88 force-pushed the PSG-5721-sdk-test-node branch from cad57ab to c8495ed Compare January 21, 2025 22:53
name: Test E2E
runs-on: ubuntu-latest
steps:
- uses: actions-cool/check-user-permission@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried using the pull_request. author_association event data as described in https://michaelheap.com/github-actions-check-permission/, but found the results to not be lined up with what was described in the blog.

other people seemed to experience the same behavior (ref, ref)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants