-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change codegen to use php 8.1 #100
base: main
Are you sure you want to change the base?
Conversation
125eb49
to
0c2763c
Compare
readonly class MagicLinkArgsBase | ||
{ | ||
public function __construct( | ||
public readonly string $type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed unnecessary readonly
access modifiers to allow devs to update the arg objects after instantiation
@@ -51,15 +51,13 @@ | |||
"autoload": { | |||
"psr-4": { | |||
"OpenAPI\\Client\\": [ | |||
"generated/lib/", | |||
"custom/models/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this directory and the one below that is also removed no longer exist
0cdcc4d
to
f3c039f
Compare
0c2763c
to
22f0c1e
Compare
f3c039f
to
556c4ae
Compare
22f0c1e
to
a5a5897
Compare
a5a5897
to
cd78ec1
Compare
What's New?
generate.sh
php-nextgen
instead ofphp
to make the generated code use PHP 8.1generated/lib
to "whitelist" instead of removing unnecessary meta files to "blacklist" themphp-nextgen
is generating return types likeOpenApi\Client\Model\Model401Error|OpenApi\Client\Model\Model404Error|etc...
instead ofvoid
likephp
used to, so this was necessary to correct the type errors from those operationscustom/
generated/
generate.sh openapi.json
against the current published spec. most of the changes seem to beuse Class
instead of using the global import syntax\Class
|null
where it was previously implicitly typed as suchtest with
Screenshots (if appropriate):
Type of change
Checklist:
Additional context