Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing deps when adding dev dependencies #3361

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (e4eb940) to head (46ea346).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
- Coverage   85.48%   85.23%   -0.25%     
==========================================
  Files         112      112              
  Lines       11469    11470       +1     
  Branches     2509     2510       +1     
==========================================
- Hits         9804     9777      -27     
- Misses       1139     1168      +29     
+ Partials      526      525       -1     
Flag Coverage Δ
unittests 85.03% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit e29740f into main Dec 30, 2024
20 of 21 checks passed
@frostming frostming deleted the fix/dev-group branch December 30, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant