Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache the result of keyring queries #3374

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix: cache the result of keyring queries #3374

merged 3 commits into from
Jan 10, 2025

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (6c52c4e) to head (57996b1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/auth.py 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
- Coverage   85.21%   85.20%   -0.01%     
==========================================
  Files         112      112              
  Lines       11482    11492      +10     
  Branches     2515     2517       +2     
==========================================
+ Hits         9784     9792       +8     
- Misses       1171     1173       +2     
  Partials      527      527              
Flag Coverage Δ
unittests 85.00% <77.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit de3ab41 into main Jan 10, 2025
20 of 21 checks passed
@frostming frostming deleted the fix/keyring-auth branch January 10, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant