build: 🛠 add upper boundary to Markupsafe to avoid breaking changes from unreleased v3 #63
Conversation
…rom unreleased v3 v3.0 of Markupsafe is described as unreleased and not stable, yet it is already on pypi. To avoid using it prematurely, we need to add this upper boundary.
|
@pelme Some checks are failing on python3.13, I need to check whether this is related to the older version of Markupsafe or not. |
|
It seems like 3.0.1 is released but not updated on the docs site: pallets/markupsafe#474 So I think 3.x should be a fine release, will look into why it is failing with htpy! |
|
Jinja also uses markupsafe>2.0 so I think people would have a ton of breakages if it was a bad release! Also: I will switch CI to use 3.13 final now that it is out. |
|
Switching to the Python 3.13 release (not release candidate) causes all tests to pass (see #45). @wolfskaempf @nip3o can you provide some more details on what is wrong with markupsafe 3.x? All internal htpy tests are passing and they are quite extensive when it comes to checking integration with Django templates and when things are expected to be escaped or not. |
|
Now that it is clear that 3.0.1 is considered stable, the approach should not be to pin the version to |
v3.0 of Markupsafe is described as unreleased and not stable, yet it is already on pypi. To avoid using it prematurely, we need to add this upper boundary.