Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDI-8731]-Cassandra SSTable Output (bulkloader) step does not work w… #81

Closed
wants to merge 1 commit into from

Conversation

egorz-eng
Copy link

…ith Cassandra 1.1.x

#66 successor

@wingman-pentaho
Copy link
Collaborator

Build Completed

✅ This pull request has passed all validations.

Build Commands

ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -f build.xml checkstyle publish-local

Cleanup Commands

rm -r ~/.ivy2/local || echo no publish local to remove

Changed files

  ivy.xml
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutput.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputDialog.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputMeta.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/messages/messages_en_US.properties
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/AbstractSSTableWriter.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/CQL2SSTableWriter.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/CQL3SSTableWriter.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/SSTableWriterBuilder.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/messages/messages_en_US.properties
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputIT.java
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputMetaTest.java
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputTest.java
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/cassandra.yaml
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/AbstractSSTableWriterTest.java
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/CQL2SSTableWriterTest.java
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/CQL3SSTableWriterTest.java
  test-src/org/pentaho/di/trans/steps/cassandrasstableoutput/writer/SSTableWriterBuilderTest.java
  test-src/org/pentaho/di/trans/steps/mock/StepMockHelper.java

Unit test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

org.pentaho.cassandra.CassandraUtils
  • Branch Change: + 1.33%
  • Complexity Change: + 1.92%
  • Instruction Change: + .63%
  • Line Change: + 1.23%
  • Method Change: + 4.35%
org.pentaho.di.trans.steps.cassandrasstableoutput.SSTableOutput
  • Complexity Change: + 11.54%
  • Instruction Change: + 4.85%
  • Line Change: + 6.67%
  • Method Change: + 42.86%
org.pentaho.di.trans.steps.cassandrasstableoutput.SSTableOutput.JVMShutdownAttemptedException
  • Complexity New Coverage: 100.00%
  • Instruction New Coverage: 100.00%
  • Line New Coverage: 100.00%
  • Method New Coverage: 100.00%
org.pentaho.di.trans.steps.cassandrasstableoutput.SSTableOutput.NoSystemExitDelegatingSecurityManager
  • Branch New Coverage: 25.00%
  • Complexity New Coverage: 50.00%
  • Instruction New Coverage: 60.61%
  • Line New Coverage: 60.00%
  • Method New Coverage: 75.00%
org.pentaho.di.trans.steps.cassandrasstableoutput.SSTableOutputMeta
  • Branch Change: + 31.25%
  • Complexity Change: + 30.00%
  • Instruction Change: + 31.56%
  • Line Change: + 38.69%
  • Method Change: + 32.05%
org.pentaho.di.trans.steps.cassandrasstableoutput.writer.AbstractSSTableWriter
  • Complexity New Coverage: 100.00%
  • Instruction New Coverage: 100.00%
  • Line New Coverage: 100.00%
  • Method New Coverage: 100.00%
org.pentaho.di.trans.steps.cassandrasstableoutput.writer.CQL2SSTableWriter
  • Branch New Coverage: 88.46%
  • Complexity New Coverage: 81.82%
  • Instruction New Coverage: 84.74%
  • Line New Coverage: 89.80%
  • Method New Coverage: 88.89%
org.pentaho.di.trans.steps.cassandrasstableoutput.writer.CQL3SSTableWriter
  • Branch New Coverage: 75.00%
  • Complexity New Coverage: 81.82%
  • Instruction New Coverage: 90.68%
  • Line New Coverage: 93.10%
  • Method New Coverage: 88.89%
org.pentaho.di.trans.steps.cassandrasstableoutput.writer.SSTableWriterBuilder
  • Branch New Coverage: 75.00%
  • Complexity New Coverage: 73.33%
  • Instruction New Coverage: 86.07%
  • Line New Coverage: 89.19%
  • Method New Coverage: 76.92%

@egorz-eng
Copy link
Author

Tested it in the Spoon. Step fails with ClassNotFound exception, so the PR needs an update.

@egorz-eng egorz-eng closed this Jun 13, 2017
buildguy pushed a commit that referenced this pull request Jan 24, 2024
[BACKLOG-24502] - Move archiving out to a separate stage again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants