-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve task creation and cancellation #1085
Open
aconchillo
wants to merge
17
commits into
main
Choose a base branch
from
aleix/task-creation-and-cancellation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbackman
changed the title
imporve task creation and cancellation
improve task creation and cancellation
Jan 24, 2025
aconchillo
force-pushed
the
aleix/task-creation-and-cancellation
branch
2 times, most recently
from
January 24, 2025 23:40
3c0ef99
to
9017c22
Compare
If a FrameProcessor needs to create a task it should use FrameProcessor.create_task() and FrameProcessor.cancel_task(). This gives Pipecat more control over all the tasks that are created in Pipecat. Both functions internally use the utils module: utils.create_task() and utils.cancel_task() which should also be used outside of FrameProcessors. That is, unless strictly necessary, we should avoid using asyncio.create_task().
aconchillo
force-pushed
the
aleix/task-creation-and-cancellation
branch
from
January 25, 2025 02:13
9017c22
to
2e15253
Compare
aconchillo
force-pushed
the
aleix/task-creation-and-cancellation
branch
from
January 25, 2025 08:38
32d40ce
to
54cade1
Compare
This is really great! I've found two issues so far:
This will result in the TTS speech overlapping—both the TextFrame and LLM text will be spoken at the same time. This isn’t happening on
|
Also, in running the twilio-chatbot example, I get some version of this frequently:
Should we be concerned about dangling tasks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
If a
FrameProcessor
needs to create a task it should useFrameProcessor.create_task()
andFrameProcessor.cancel_task()
. This gives Pipecat more control over all the tasks that are created in Pipecat.Both functions internally use the utils module:
utils.create_task()
andutils.cancel_task()
which should also be used outside of FrameProcessors. That is, unless strictly necessary, we should avoid usingasyncio.create_task()
.