e2e-test: use hot keys to focus variables in tests #6119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
testlabauto
reviewed
Jan 24, 2025
|
|
||
| await app.workbench.quickaccess.openDataFile(join(app.workspacePathOrFolder, 'data-files', '100x100', '100x100.parquet')); | ||
| await openDataFile('data-files/100x100/100x100.parquet'); |
There was a problem hiding this comment.
This will be a problem on windows. You still need to use join
There was a problem hiding this comment.
I think... lol... did it somehow pass on windows?
There was a problem hiding this comment.
I did run it on windows (and it passed). :) It's a fixture and the fixture does the "join".
There was a problem hiding this comment.
fixture snippet:
openDataFile: async ({ app }, use) => {
await use(async (filePath: string) => {
await test.step(`Open data file: ${path.basename(filePath)}`, async () => {
await app.workbench.quickaccess.openDataFile(path.join(app.workspacePathOrFolder, filePath));
});
});
},
jonvanausdeln
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating tests to use hot keys to focus variables review instead of quick access because it's quicker and likely more reliable... and ensures they work as expected.
QA Notes
@:data-explorer @:win @:web