Fix touch input cancellation no longer being handled in latest SDL #6484
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
3 tasks
|
I've moved this commit to #6511, so I can make additional changes and write a proper description for bumping SDL3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR'ing this on the side as we bump SDL, turns out cancelled touches have been separated out from
SDL_EVENT_FINGER_UPand to being their own event type, this is a silent failure so I'm explicitly opening a PR to keep track of it. See https://discourse.libsdl.org/t/sdl-added-sdl-event-finger-canceled/56427.I've added the "update SDL" task here as it is a good place to do it.