Fix osu!mania judgement position not shifted on flipped scroll direction #31682
+546
−416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves display in portrait screen, where the stage is scaled up.
Similar to mania's `ArgonJudgementPiece`.
i.e. editor mania ruleset
- Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well) - Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.
Co-authored-by: Susko3 <[email protected]>
This reverts commit e5713e5.
This reverts commit 6ec7183.
Co-authored-by: Dean Herbert <[email protected]>
Everyone is right, too much inheritance and polymorphism backfires very badly.
Co-authored-by: Dean Herbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became more of an issue with the judgement positioning changes in #31368. That can be best demonstrated with visual snippets of gameplay on master / #31368.
Now the position of judgements are flipped upside down when flipping the scroll direction, relative to the position of the hit target. This matches stable, and should be a good change overall given that judgement indication should be closer to the player instead of being far away from them.
master:
CleanShot.2025-01-25.at.20.22.36.mp4
#31368 :
CleanShot.2025-01-25.at.20.23.40.mp4
this PR:
CleanShot.2025-01-25.at.20.21.29.mp4