Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not manage hanging windows #71

Closed
wants to merge 2 commits into from
Closed

Do not manage hanging windows #71

wants to merge 2 commits into from

Conversation

nir9
Copy link
Contributor

@nir9 nir9 commented Dec 19, 2023

Problem: When dwm-win32 manages non-responding windows it also gets to a non-responding mode

Solution: Avoid managing windows that Windows determines as not responding or windows that are managed by a process that is debugged

@nir9 nir9 marked this pull request as draft December 19, 2023 16:39
@prabirshrestha
Copy link
Owner

If a window is hanged and managed, should we call unmanage()?

@nir9 nir9 changed the title Do not manage non-responding windows Do not manage hanging windows Jan 14, 2024
@nir9 nir9 marked this pull request as ready for review January 14, 2024 07:24
@nir9
Copy link
Contributor Author

nir9 commented Jan 14, 2024

@prabirshrestha good point, I fixed the code with unmanaging as well in case the window is hanged, and also I added a check if the process of the window is being debugged, since this also currently causes dwm to hang

@adham-elaraby
Copy link

Hey @nir9, I appreciate all the work that has gone into this, while this has improved stability, I can still reproduce crashes randomly using certain features of Zoom meetings, but also 100% of the time upon trying to run a program called ToneLib GFX, based on my initial testing of this PR.

Unsure how to log any information on the cause.

Windows 10 Home 22H2

@nir9
Copy link
Contributor Author

nir9 commented Jan 27, 2024

@adham-elaraby Thanks, I have recently started my own tiling WM for Windows project, so I don't plan on maintaining this PR anymore.

@nir9 nir9 closed this by deleting the head repository Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants