Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup gpuinfo.sh for amd gpu #2093

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

zeerayne
Copy link
Contributor

@zeerayne zeerayne commented Jan 5, 2025

Pull Request

Description

On AMD GPUs gpuinfo.sh had one minor problem: Utilization always show "lowest" gauge icon not respecting the actual gpu load because of empty "utilization" variable on row 154

{"text":" 38°C", "tooltip":"AMD Navi 14\n Temperature: 38°C ❄️\n󰾆 Utilization: 0.2%\n󱪉 Power Usage: 7 W\n Clock Speed: 492 MHz"}

{"text":" 86°C", "tooltip":"AMD Navi 14\n Temperature: 86°C 🌋\n󰾆 Utilization: 96.4%\n󱪉 Power Usage: 122 W\n Clock Speed: 850 MHz"}

This change rename gpu_load -> utilization in amd_GPU() function to match intel & nvidia functions.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@zeerayne
Copy link
Contributor Author

@kRHYME7 can you kindly check this one? Minor fix in one script

@kRHYME7 kRHYME7 merged commit 4a9d80b into prasanthrangan:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants