Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing FloatThriftCodec and FloatArrayThriftCodec #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implementing FloatThriftCodec and FloatArrayThriftCodec #57

wants to merge 1 commit into from

Conversation

divyatalesra-2001
Copy link

@divyatalesra-2001 divyatalesra-2001 commented Jan 16, 2025 •
edited
Loading

Summary

  • Added implementations for FloatThriftCodec and FloatArrayThriftCodec and updated other relevant files to allow for proper deserialization of list of floats in Java
  • Updated existent unit tests

Testing

  • Ran the updated unittests in AbstractThriftCodecManagerTest.java to ensure they pass (most notably, testArrays() and testArraysManual())

@divyatalesra-2001 divyatalesra-2001 requested a review from a team as a code owner January 16, 2025 21:40
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 16, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

NikhilCollooru
NikhilCollooru reviewed Jan 16, 2025
View reviewed changes
Copy link

@NikhilCollooru NikhilCollooru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some unit tests ?

@divyatalesra-2001 divyatalesra-2001 force-pushed the adding_float_thrift_codec branch 3 times, most recently from c9defd2 to 602e51f Compare January 24, 2025 06:19
@divyatalesra-2001 divyatalesra-2001 force-pushed the adding_float_thrift_codec branch from 602e51f to a8407fa Compare January 24, 2025 21:25
@divyatalesra-2001 divyatalesra-2001 changed the title added float thrift codec Adding FloatThriftCodec and FloatArrayThriftCodec Jan 24, 2025
@divyatalesra-2001 divyatalesra-2001 changed the title Adding FloatThriftCodec and FloatArrayThriftCodec Implementing FloatThriftCodec and FloatArrayThriftCodec Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikhilCollooru NikhilCollooru NikhilCollooru left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyatalesra-2001 @NikhilCollooru