[native] Fix varchar cast for json #24396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
natashasehgal
force-pushed
the
export-D68353517
branch
from
f6c1132 to
98a84af
Compare
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 21, 2025
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
|
@natashasehgal Thanks for the fix. Please publish the PR, its in draft mode. Also make the PR title and commit message following Lets also follow the PR template and fill in accordingly. |
natashasehgal
changed the title
amitkdutta
reviewed
Jan 22, 2025
presto-native-execution/presto_cpp/main/types/tests/RowExpressionTest.cpp
Outdated
Show resolved
Hide resolved
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 22, 2025
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
natashasehgal
force-pushed
the
export-D68353517
branch
from
98a84af to
5309841
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 22, 2025
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
natashasehgal
force-pushed
the
export-D68353517
branch
from
5309841 to
84144d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
amitkdutta
previously approved these changes
Jan 22, 2025
kgpai
previously approved these changes
Jan 22, 2025
gggrace14
requested changes
Jan 23, 2025
presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp
Outdated
Show resolved
Hide resolved
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 24, 2025
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
natashasehgal
force-pushed
the
export-D68353517
branch
from
84144d1 to
997643c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 24, 2025
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
natashasehgal
force-pushed
the
export-D68353517
branch
from
997643c to
1a3f520
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
kgpai
reviewed
Jan 24, 2025
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 24, 2025
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
natashasehgal
force-pushed
the
export-D68353517
branch
from
1a3f520 to
5cafb02
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
Summary: https://www.internalfb.com/tasks/?t=211442303 There was an error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)". This is not due to missing function, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length. Related Diff: https://www.internalfb.com/diff/D59531026 Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR Differential Revision: D68353517
natashasehgal
force-pushed
the
export-D68353517
branch
from
5cafb02 to
35b8915
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68353517 |
Yes. @kgpai could you please point me to a suitable location to add an e2e test? I wasn't able to find an e.g for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve error in running query on Prestissimo not Presto - "Scalar function presto.default.substr not registered with arguments: (JSON, BIGINT, BIGINT)".
Motivation and Context
This is not due to missing function in Prestissimo, as the function signature does not exist in Presto. It occurs when attempting to cast JSON as varchar of capped length.
Note: Exception is still raised for try_cast() behavior. Alignment is out of scope for this PR
Impact
N/A
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.