Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience functions to remove headers and trailers. #256

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

itsLucario
Copy link
Contributor

@itsLucario itsLucario commented Aug 28, 2024

This is a convenient method to remove request header by key than using set_http_request_header with empty value. Since we already have the things in place, it's just about exposing it for usage with HttpContext.

Copy link

google-cla bot commented Aug 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@itsLucario itsLucario force-pushed the nbn01-add-remove-header branch from d61c8d3 to 9536299 Compare August 28, 2024 06:44
src/hostcalls.rs Outdated Show resolved Hide resolved
src/traits.rs Show resolved Hide resolved
@PiotrSikora PiotrSikora changed the title add: remove_http_request_header convenient func Add convenience functions to remove headers and trailers. Jan 15, 2025
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit 8604c64 into proxy-wasm:main Jan 15, 2025
23 checks passed
thibaultcha pushed a commit to Kong/proxy-wasm-rust-sdk that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants