-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG - center search dialog on wide screens #2085
base: main
Are you sure you want to change the base?
Conversation
I tested this PR locally on my machine on Firefox, Safari, Chrome. I also tested on the iOS simulator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this had been bugging me!
form.bd-search { | ||
flex-grow: 1; | ||
form.bd-search { | ||
flex-grow: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just found this PR)
The search-as-you-type UX I contributed in #2093 conflicts with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've resolved conflicts correctly, but RTD build is still stalled by #2083 😢 so I can't check the PR build to make sure things still look OK
@kaycebasques can you check the diff here to make sure I didn't bungle the merge / kept the important parts from #2093?
cd1c09c
to
8539bcc
Compare
well the centering looks good, but I seem to have lost the opacity of the search results popup container: https://pydata-sphinx-theme--2085.org.readthedocs.build/en/2085/ |
I noticed while reading the docs that on very wide screens, the search dialog was off center.
This PR gets rid of all unnecessary CSS that was left over from when the search dialog was implemented without the built-in benefits of the HTML modal dialog element.
How to test