Add initial experimental multi database support #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
force-pushed
the
multi-db
branch
3 times, most recently
from
034a5d8 to
b25504e
Compare
|
EY @bluetech, I have a function test that access to a Mongo and Postgres, This is a mix between TransactionalTestCase and TestCase, but it seems to be that the entire test is wrapped in a TransactionalTestCase because the Postgres is flushed too, This should not happen since transaction=False is being specified in the marker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental support for multi-database configurations - refs #924.
Currently, we only add a
databasesargument to thedjango_dbmarker, which corresponds to thedatabasesattribute of Django'sTransactionTestCase/TestCase. We probably also want some fixture to be able to control this more nicely for an entire file, module, session etc, but that can be done later.Since I'm not really sure about the API, I marked it as experimental for now. If it works out fine, we can stabilize it.