typing: Improve FixtureDefinition and FixtureDef #12999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an internal class users don't need to know about it.
for more information, see https://pre-commit.ci
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
psf-chronographer
bot
added
the
bot:chronographer:provided
Tusenka
approved these changes
Dec 1, 2024
|
@nicoddemus can you open a pr against the branch @Glyphack has from your branch and link it, so the change can be seen in relation to his pr |
|
@RonnyPfannschmidt this is not really ready to review or merge, I only wanted to open the PR to make sure I did not lose my local commits, hehehe. |
Tusenka
reviewed
Dec 4, 2024
| @@ -124,7 +130,7 @@ def pytest_sessionstart(session: Session) -> None: | |||
|
|
|||
| def get_scope_package( | |||
| node: nodes.Item, | |||
| fixturedef: FixtureDef[object], | |||
| fixturedef: FixtureDef[Any, object], | |||
There was a problem hiding this comment.
It's for filling the new generic parameter for the arguments
Tusenka
reviewed
Dec 4, 2024
| if inspect.isclass(function): | ||
| raise ValueError("class fixtures not supported (maybe in the future)") | ||
|
|
||
| if getattr(function, "_pytestfixturefunction", False): | ||
| if isinstance(function, FixtureFunctionDefinition): | ||
| raise ValueError( |
There was a problem hiding this comment.
in which cases this error could be raised?
|
Superseded by #13036. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12473, built on top of it, not ready to merge.