Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups #1170

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Small cleanups #1170

merged 12 commits into from
Jan 14, 2025

Conversation

akx
Copy link
Member

@akx akx commented Jan 13, 2025

Ran PyCharm's "Inspect Code" and found a bunch of actionable things. (And a bunch of less actionable ones, which were thus not actioned upon.)

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (8e10fb5) to head (7a576d2).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   91.31%   91.33%   +0.01%     
==========================================
  Files          27       27              
  Lines        4653     4650       -3     
==========================================
- Hits         4249     4247       -2     
+ Misses        404      403       -1     
Flag Coverage Δ
macos-14-3.10 90.34% <100.00%> (+0.01%) ⬆️
macos-14-3.11 90.27% <100.00%> (+0.01%) ⬆️
macos-14-3.12 90.49% <100.00%> (+0.01%) ⬆️
macos-14-3.13 90.49% <100.00%> (+0.01%) ⬆️
macos-14-3.8 90.20% <100.00%> (+0.01%) ⬆️
macos-14-3.9 90.27% <100.00%> (+0.01%) ⬆️
macos-14-pypy3.10 90.34% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.10 90.36% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.11 90.30% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.12 90.51% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.13 90.51% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.8 90.23% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.9 90.29% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-pypy3.10 90.36% <100.00%> (+0.01%) ⬆️
windows-2022-3.10 90.37% <100.00%> (+0.01%) ⬆️
windows-2022-3.11 90.31% <100.00%> (+0.01%) ⬆️
windows-2022-3.12 90.52% <100.00%> (+0.01%) ⬆️
windows-2022-3.13 90.52% <100.00%> (+0.01%) ⬆️
windows-2022-3.8 90.34% <100.00%> (+0.01%) ⬆️
windows-2022-3.9 90.30% <100.00%> (+0.01%) ⬆️
windows-2022-pypy3.10 90.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review January 13, 2025 12:05
@akx akx requested a review from tomasr8 January 13, 2025 12:05
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

babel/messages/catalog.py Show resolved Hide resolved
@akx akx merged commit db48791 into master Jan 14, 2025
26 checks passed
@akx akx added this to the Babel 2.17 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants