Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Literal from the typing module #1175

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jan 16, 2025

typing.Literal was added in 3.8. We can import it directly instead of relying on typing_extensions.

Edit: TypedDict as well

cc @akx

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (98b9562) to head (414e8db).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          27       27           
  Lines        4672     4672           
=======================================
  Hits         4269     4269           
  Misses        403      403           
Flag Coverage Δ
macos-14-3.10 90.38% <100.00%> (ø)
macos-14-3.11 90.32% <100.00%> (ø)
macos-14-3.12 90.53% <100.00%> (ø)
macos-14-3.13 90.53% <100.00%> (ø)
macos-14-3.8 90.25% <100.00%> (ø)
macos-14-3.9 90.31% <100.00%> (ø)
macos-14-pypy3.10 90.38% <100.00%> (ø)
ubuntu-24.04-3.10 90.41% <100.00%> (ø)
ubuntu-24.04-3.11 90.34% <100.00%> (ø)
ubuntu-24.04-3.12 90.56% <100.00%> (ø)
ubuntu-24.04-3.13 90.56% <100.00%> (ø)
ubuntu-24.04-3.8 90.27% <100.00%> (ø)
ubuntu-24.04-3.9 90.34% <100.00%> (ø)
ubuntu-24.04-pypy3.10 90.41% <100.00%> (ø)
windows-2022-3.10 90.42% <100.00%> (ø)
windows-2022-3.11 90.35% <100.00%> (ø)
windows-2022-3.12 90.57% <100.00%> (ø)
windows-2022-3.13 90.57% <100.00%> (ø)
windows-2022-3.8 90.39% <100.00%> (ø)
windows-2022-3.9 90.35% <100.00%> (ø)
windows-2022-pypy3.10 90.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite literal!

@akx akx merged commit 2d8a808 into python-babel:master Jan 25, 2025
26 checks passed
@tomasr8 tomasr8 deleted the typing-literal branch January 25, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants