Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete serve target from make.bat. #1365

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Aug 8, 2024

This is a follow-up of:

The PR removed the make serve target from the Makefile but not from make.bat.


Slightly unrelated, but I noticed that the serve replacement -- htmllive -- seems to be missing from make.bat. htmllive (formerly known as autobuild) was introduced in:


📚 Documentation preview 📚: https://cpython-devguide--1365.org.readthedocs.build/

@ezio-melotti ezio-melotti requested a review from hugovk August 8, 2024 14:12
@ezio-melotti ezio-melotti self-assigned this Aug 8, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly unrelated, but I noticed that the serve replacement -- htmllive -- seems to be missing from make.bat.

I probably skipped it because I don't have Windows to test it on. But it's so useful, I'd recommend someone with Windows adds it.

@hugovk hugovk merged commit b2d4974 into python:main Aug 8, 2024
5 checks passed
@AA-Turner
Copy link
Member

I don't think I've once used make.bat, to be honest. One of those Sphinx people should really look into making their CLI better...!

A

@ezio-melotti ezio-melotti deleted the rm-serve-make-bat branch August 8, 2024 15:03
@ezio-melotti
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants