Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporarily add packaging as CI requirement #8100

Merged
merged 1 commit into from
Nov 7, 2023
Merged

temporarily add packaging as CI requirement #8100

merged 1 commit into from
Nov 7, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Nov 7, 2023 •
edited by pytorch-bot bot
Loading

This can be reverted when pytorch/pytorch#113154 is merged or the underlying issue is fixed upstream.

cc @seemethere

@pmeier pmeier requested review from NicolasHug and vfdev-5 November 7, 2023 14:59
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8100

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (9 Unrelated Failures)

As of commit a88345a with merge base f69eee6 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier
Copy link
Collaborator Author

pmeier commented Nov 7, 2023

CUDA builds are failing for an unrelated error. Will look into that next.

@pmeier pmeier merged commit ef2c281 into main Nov 7, 2023
55 of 64 checks passed
@pmeier pmeier deleted the tmp-packaging branch November 7, 2023 15:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

pmeier added a commit to pmeier/vision that referenced this pull request Nov 14, 2023
@pmeier
Revert "temporarily add packaging as CI requirement (pytorch#8100)"
b1a20ee 
This reverts commit ef2c281.
@pmeier pmeier mentioned this pull request Nov 14, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2023
@NicolasHug @facebook-github-bot
[fbsync] temporarily add packaging as CI requirement (#8100)
34f7aa6 
Reviewed By: vmoens

Differential Revision: D51391969

fbshipit-source-id: 3fdc3216af02c091b062666bdc84d8b08116288c
pmeier added a commit to pmeier/vision that referenced this pull request Nov 23, 2023
@pmeier
Revert "temporarily add packaging as CI requirement (pytorch#8100)"
a143f8f 
This reverts commit ef2c281.
pmeier added a commit that referenced this pull request Nov 23, 2023
@pmeier
Revert "temporarily add packaging as CI requirement (#8100)" (#8131)
83090c2
facebook-github-bot pushed a commit that referenced this pull request Jan 15, 2024
@NicolasHug @facebook-github-bot
[fbsync] Revert "temporarily add packaging as CI requirement (#8100)" (…
2393bff 
…#8131)

Reviewed By: vmoens

Differential Revision: D52539008

fbshipit-source-id: e88d4d85cdeb0cb2ced6aedbc83a00f52b81d24d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed core issue module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot