fix!: remove handling of types not present in type signatures #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minhir
approved these changes
Jul 4, 2024
3 tasks
aleclarson
force-pushed
the
main
branch
2 times, most recently
from
2154f96 to
6a4b4f6
Compare
aleclarson
force-pushed
the
breaking/remove-undefined-checks
branch
from
a6d708e to
85bd936
Compare
Benchmark Results
Performance regressions of 30% or more should be investigated, unless they were anticipated. Smaller regressions may be due to normal variability, as we don't use dedicated CI infrastructure. |
[skip ci]
aleclarson
force-pushed
the
breaking/remove-undefined-checks
branch
from
38dd7b8 to
0e05f8e
Compare
aleclarson
changed the title
|
This PR has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
This PR removes any implicit handling of null/undefined input values.
Some notes:
replaceandreplaceOrAppendstill skip an undefineditemargumentif (!array.length)checks were also removed, preferring brevity over performance for those code paths. I'd be fine with reinstating these checks on a case-by-case basis if benchmarks prove a substantial benefit and the frequency of empty arrays being passed is deemed common.See the linked discussion for the philosophy behind this change.
Related issue, if any:
https://github.com/orgs/radashi-org/discussions/48
For any code change,
Does this PR introduce a breaking change?
Yes
As of now, a codemod will not be provided. Implicit nullish handling was never actually documented, so I assume most Radash users will not be affected.
Bundle impact
src/array/alphabetical.tssrc/array/boil.tssrc/array/counting.tssrc/array/diff.tssrc/array/first.tssrc/array/fork.tssrc/array/intersects.tssrc/array/last.tssrc/array/merge.tssrc/array/replace.tssrc/array/replaceOrAppend.tssrc/array/select.tssrc/array/selectFirst.tssrc/array/sort.tssrc/array/toggle.tssrc/array/unzip.tssrc/array/zipToObject.tssrc/async/map.tssrc/async/reduce.tssrc/number/inRange.tssrc/number/max.tssrc/number/min.tssrc/object/assign.tssrc/object/clone.tssrc/object/construct.tssrc/object/crush.tssrc/object/invert.tssrc/object/keys.tssrc/object/listify.tssrc/object/mapEntries.tssrc/object/omit.tssrc/object/pick.tssrc/object/set.tssrc/object/shake.tssrc/string/camel.tssrc/string/capitalize.tssrc/string/dash.tssrc/string/pascal.tssrc/string/snake.tssrc/string/title.tssrc/string/trim.tsFootnotes
Function size includes the
importdependencies of the function. ↩