New interface for PKCS8 key encryption #4593
Draft
+359
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/pkcs8-enc
branch
from
8e4c42b to
6657a4b
Compare
|
Some things to work out
|
randombit
force-pushed
the
jack/pkcs8-enc
branch
2 times, most recently
from
34c7c9f to
212e628
Compare
Quite a few interfaces exist for this but there really are only two things that change between them: if the PBKDF runtime is specified in "iterations" or in a duration, and if the result is PEM encoded or not. Add a new single interface for PKCS8 encryption, PKCS8::encrypt_private_key, then define all of the previously existing functions in terms of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few interfaces exist for this but there really are only two things that change between them: if the PBKDF runtime is specified in "iterations" or in a duration, and if the result is PEM encoded or not.
Add a new single interface for PKCS8 encryption, PKCS8::encrypt_private_key, then define all of the previously existing functions in terms of that.