Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fancy-text extension #16233

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Jan 9, 2025

Description

Added a new command, Fancy Selected Text, to turn selected text into fancy text.
Close #16224

Screencast

CleanShot.2025-01-09.at.13.38.48.mp4

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: fancy-text Issues related to the fancy-text extension labels Jan 9, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 9, 2025

Thank you for your contribution! 🎉

🔔 @peduarte you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@ridemountainpig ridemountainpig changed the title Fancy text Update fancy-text extension Jan 9, 2025
@pernielsentikaer
Copy link
Collaborator

@peduarte do you want to check this?

@raycastbot raycastbot added the OP is contributor The OP of the PR is a contributor of the extension label Jan 15, 2025
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit f70d1dd into raycast:main Jan 15, 2025
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/peduarte/fancy-text

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@peduarte
Copy link
Contributor

peduarte commented Jan 15, 2025

Sorry, Im a bit late for this. But why did we make a dedicated command for this, instead of relying on the previous one, but just use the selected text if available? That way, users dont need to memorise 2 different commands, and can rely on just one (and one hotkey)

@ridemountainpig
Copy link
Contributor Author

Sorry, Im a bit late for this. But why did we make a dedicated command for this, instead of relying on the previous one, but just use the selected text if available? That way, users dont need to memorise 2 different commands, and can rely on just one (and one hotkey)

@peduarte Sorry, I didn't notice that. I will combine these two commands into one. Thank you for your comment.

@ridemountainpig ridemountainpig deleted the fancy-text branch January 15, 2025 14:43
@peduarte
Copy link
Contributor

Thanks. cc @pernielsentikaer can we prioritise that PR so the breaking change is short-lived? Thanks fam

@pernielsentikaer
Copy link
Collaborator

I'm not sure I would actually like that - most of the time, I would need to remove it - an example from a code editor

CleanShot 2025-01-16 at 10 55 20@2x

I didn't select anything, but still takes the line fully

@peduarte
Copy link
Contributor

@pernielsentikaer thats a very annoying thing with how vscode treats selected text — no one will use this extension in code editors

i think we favour simplicity and stick with 1 command, we can always add another later if needed, but lets try and keep it simple pleeeease

@pernielsentikaer
Copy link
Collaborator

Same issue right here in GitHub, didn't select anything
CleanShot 2025-01-16 at 10 59 57@2x

@pernielsentikaer
Copy link
Collaborator

But sure, let's just add it to the current one if that's better - @ridemountainpig do you want to do that or should I?

@ridemountainpig
Copy link
Contributor Author

I can work on it. Thanks!

@pernielsentikaer
Copy link
Collaborator

Awesome, thanks 🫶

@ridemountainpig
Copy link
Contributor Author

ridemountainpig commented Jan 16, 2025

@pernielsentikaer I updated it in this pull request #16404. Please check it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: fancy-text Issues related to the fancy-text extension extension fix / improvement Label for PRs with extension's fix improvements OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fancy Text] ...
4 participants