Ci Fixes #1336
Merged
Ci Fixes #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Judahmeek
force-pushed
the
judahmeek/ci-sanity-check
branch
from
4ca5db5 to
081e33c
Compare
G-Rath
approved these changes
Apr 14, 2024
| @@ -89,7 +89,7 @@ jobs: | |||
| with: | |||
| persist-credentials: false | |||
| - uses: actions/setup-node@v3 | |||
| - run: npm -g install yalc ${{ matrix.js_package_manager.installer }} | |||
| - run: sudo npm -g install yalc ${{ matrix.js_package_manager.installer }} | |||
There was a problem hiding this comment.
Seems weird that we have to use sudo but not that concerned since this in a temp CI runner 😁
(I figure it might be related to supporting old versions of Node and what not)
There was a problem hiding this comment.
The sudo is to resolve a EACCES: permission denied error that I was getting.
The other option I saw in my search was --unsafe-perm, but that's apparently obsolete.
justin808
reviewed
Apr 15, 2024
| @@ -4,3 +4,6 @@ source "http://rubygems.org" | |||
|
|
|||
| gemspec | |||
| # This is an optional dev-dependency, required whenever sprockets is required | |||
| gem "rubocop" | |||
There was a problem hiding this comment.
why not in the gemspec as a development dependency?
There was a problem hiding this comment.
Because CI doesn't install development dependencies from the gemspec.
Do you want me to create a Gemfile.development_dependencies file like react_on_rails has?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses linting and some other CI issues in preparation for #1335