Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest {queryArg, pageParam} for infinite queries #4826

Merged

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Switches from passing pageParam directly to infinite query query and queryFn methods, to passing a combined {queryArg, pageParam} object, equivalent to how React Query does it

Copy link

codesandbox bot commented Jan 23, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codesandbox-ci bot commented Jan 23, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25e7779:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

github-actions bot commented Jan 23, 2025

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit/query/react (modern.mjs) 14.39 KB (+0.15% 🔺)
1. entry point: @reduxjs/toolkit/query (cjs, production.min.cjs) 23.26 KB (+0.3% 🔺)
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 25.63 KB (+0.05% 🔺)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs, production.min.cjs) 10.04 KB (+0.15% 🔺)
3. createApi (.modern.mjs) 14.79 KB (+0.14% 🔺)
3. createApi (react) (.modern.mjs) 16.83 KB (+0.08% 🔺)

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 25e7779
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6791a77c21f2bb0008c35cd0
😎 Deploy Preview https://deploy-preview-4826--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markerikson markerikson changed the title Nest {queryArg, pageParam} for infinite queries Nest {queryArg, pageParam} for infinite queries Jan 23, 2025
@markerikson markerikson merged commit e18b966 into feature/infinite-query-integration Jan 23, 2025
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant