use rollup #4928
use rollup #4928
Conversation
WalkthroughThis pull request focuses on enhancing the configuration and build process for the Rollup plugin package. Changes include updates to the ESLint rules for dependency management, modifications to the Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Build as Rollup Build
participant TS as TypeScript Compiler
participant Dist as Dist Directory
Dev->>Build: Trigger build
Build->>TS: Compile source
TS-->>Build: Generate compiled files
Build->>Dist: Output ESM module
Build->>Dist: Output CommonJS module
Build->>Dist: Generate type declarations
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms (16)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/rollup-plugin/rollup.config.mjs (1)
1-27: LGTM! Well-structured dual-format build configuration.The configuration correctly handles both ESM and CommonJS outputs with proper file extensions and sourcemaps.
Consider adding production optimizations:
export default defineConfig([ { input: './src/index.ts', output: { dir: './dist', format: 'esm', entryFileNames: '[name].mjs', chunkFileNames: 'chunks/[name].mjs', sourcemap: true, + generatedCode: 'es2015', + minifyInternalExports: true }, plugins: [typescript({ tsconfig: './tsconfig.json' })], + external: ['rollup'], // Assuming rollup is a peerDependency }, // Similar changes for CommonJS config ]);packages/rollup-plugin/tsconfig.json (1)
7-7: Consider additional TypeScript options for better build output.While moving declarations to './dist' is correct, consider adding these options for improved output:
{ "compilerOptions": { "noEmit": false, "module": "Node16", "declaration": true, "declarationDir": "./dist", + "declarationMap": true, + "sourceMap": true, + "stripInternal": true } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.eslintrc.js(2 hunks)packages/rollup-plugin/.gitignore(1 hunks)packages/rollup-plugin/package.json(4 hunks)packages/rollup-plugin/rollup.config.mjs(1 hunks)packages/rollup-plugin/tsconfig.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (6)
.eslintrc.js (1)
46-46: LGTM! Appropriate ESLint rules for config files.The added patterns correctly allow configuration files to be imported as devDependencies, which is necessary for the Rollup setup.
Also applies to: 87-87
packages/rollup-plugin/.gitignore (1)
10-10: LGTM! Updated ignore patterns match new build structure.The addition of 'dist' to .gitignore aligns with the new Rollup output configuration.
packages/rollup-plugin/tsconfig.json (1)
5-5: LGTM! Appropriate module resolution for Node.js compatibility.The "Node16" module setting ensures proper resolution for both ESM and CommonJS formats.
packages/rollup-plugin/package.json (3)
Line range hint
60-69: LGTM! Dependencies are well configuredThe dependency changes look good:
- Added TypeScript plugin for Rollup
- Appropriate version ranges in both dev and peer dependencies
- Consistent with the migration to Rollup
Line range hint
1-76: Verify package.json completenessThe package.json appears complete but let's verify all essential fields are present and correctly configured for a public npm package.
Run these checks:
✅ Verification successful
Package.json configuration is complete and correct
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for essential package.json fields jq -r '. | select(.name and .version and .main and .license and .repository)' packages/rollup-plugin/package.json # Verify package name availability npm view rollup-plugin-bundle-stats # Check if any similar packages exist npm search rollup-plugin-bundleLength of output: 8741
23-24: Verify TypeScript type generation in the build processThe build script might need to explicitly generate TypeScript declaration files. The current Rollup configuration should be verified to ensure it handles type generation correctly.
Run this script to check if the Rollup config includes TypeScript type generation:
✅ Verification successful
Type generation is properly configured ✅
The build process already includes TypeScript type generation through
@rollup/plugin-typescriptwith proper configuration in both ESM and CommonJS build targets.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if rollup config handles type generation ast-grep --pattern 'plugin($typescript|$ts)($$$)' packages/rollup-plugin/rollup.config.mjsLength of output: 92
Script:
#!/bin/bash # Check rollup config content echo "=== Rollup Config ===" cat packages/rollup-plugin/rollup.config.mjs echo -e "\n=== TypeScript Config ===" fd tsconfig.json packages/rollup-plugin/ echo -e "\n=== Package Dependencies ===" cat packages/rollup-plugin/package.json | jq '.dependencies, .devDependencies'Length of output: 1462
#11867 Bundle Size — 380.78KiB (0%).b6ecf9b(current) vs 15ce872 master#11866(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #11867 |
Baseline #11866 |
|
|---|---|---|
 Initial JS |
333.89KiB |
333.89KiB |
| Initial CSS |
46.89KiB |
46.89KiB |
| Cache Invalidation |
0% |
0% |
| Chunks |
3 |
3 |
| Assets |
4 |
4 |
| Modules |
700 |
700 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
39 |
39 |
| Duplicate Packages |
1 |
1 |
Bundle size by type no changes
| Current #11867 |
Baseline #11866 |
|
|---|---|---|
| JS |
333.89KiB |
333.89KiB |
| CSS |
46.89KiB |
46.89KiB |
Bundle analysis report Branch use-rollup Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/rollup-plugin/package.json (1)
Line range hint
48-62: Review dependencies configuration
- Consider using caret ranges for Rollup plugins to ease updates
- Some Rollup plugins are outdated and should be updated
rollup-plugin-webpack-statsshould be independenciesas it's likely needed at runtimeApply these changes:
- "@rollup/plugin-commonjs": "28.0.2", - "@rollup/plugin-json": "6.1.0", - "@rollup/plugin-node-resolve": "16.0.0", - "@rollup/plugin-typescript": "12.1.2", + "@rollup/plugin-commonjs": "^25.0.0", + "@rollup/plugin-json": "^6.1.0", + "@rollup/plugin-node-resolve": "^25.0.0", + "@rollup/plugin-typescript": "^12.1.2",Move webpack-stats plugin back to dependencies:
- "devDependencies": { - "rollup-plugin-webpack-stats": "0.4.1", + "dependencies": { + "rollup-plugin-webpack-stats": "^0.4.1",
🧹 Nitpick comments (1)
packages/rollup-plugin/package.json (1)
15-16: Improve build scripts configuration
- The build script changes directory which can be error-prone
- The clean script should also remove the types directory
- Missing script to generate type definitions
Consider this improved configuration:
- "build": "npm run clean && cd ../../ && rollup -c packages/rollup-plugin/rollup.config.mjs", - "clean": "rimraf dist", + "build": "npm run clean && rollup -c rollup.config.mjs", + "build:types": "tsc --emitDeclarationOnly --outDir dist", + "build:all": "npm run build && npm run build:types", + "clean": "rimraf dist types",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
packages/rollup-plugin/.eslintignore(1 hunks)packages/rollup-plugin/.gitignore(1 hunks)packages/rollup-plugin/package.json(4 hunks)packages/rollup-plugin/rollup.config.mjs(1 hunks)packages/rollup-plugin/tsconfig.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/rollup-plugin/.eslintignore
🚧 Files skipped from review as they are similar to previous changes (3)
- packages/rollup-plugin/rollup.config.mjs
- packages/rollup-plugin/.gitignore
- packages/rollup-plugin/tsconfig.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/rollup-plugin/package.json (1)
5-7: 🛠️ Refactor suggestionAdd module field and align output paths
- Add the
modulefield for ESM support- Ensure consistency between output paths:
mainpoints todist/typespoints totypes/- Consider moving type definitions to
dist/for consistencyApply this diff:
"main": "./dist/index.js", + "module": "./dist/index.mjs", "types": "types/index.d.ts",Also, consider adding an
exportsfield to support both CJS and ESM:+ "exports": { + ".": { + "types": "./dist/index.d.ts", + "import": "./dist/index.mjs", + "require": "./dist/index.js" + } + },Likely invalid or redundant comment.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/html-templates/scripts/bundle-template.js (1)
12-13: Consider using async file operations.For better performance with large files, consider using async versions of the file operations.
-fs.mkdirSync(OUT_DIR, { recursive: true }); -fs.writeFileSync(path.join(OUT_DIR, 'index.js'), output); +async function writeOutput(output) { + await fs.promises.mkdir(OUT_DIR, { recursive: true }); + await fs.promises.writeFile(path.join(OUT_DIR, 'index.js'), output); +} +writeOutput(output).catch(error => { + console.error('Failed to write output:', error); + process.exit(1); +});packages/html-templates/package.json (1)
9-10: Consider adding build script validation.The new two-step build process could benefit from additional validation to ensure the template build succeeds before running the bundler.
- "build:template": "cross-env NODE_ENV=production webpack --config webpack.config.production.js --mode production", - "build": "npm run build:template && ./scripts/bundle-template.js", + "build:template": "cross-env NODE_ENV=production webpack --config webpack.config.production.js --mode production", + "validate:template": "node -e \"require('fs').accessSync('./dist-template/index.html')\"", + "build": "npm run build:template && npm run validate:template && ./scripts/bundle-template.js",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/html-templates/.gitignore(1 hunks)packages/html-templates/index.js(0 hunks)packages/html-templates/package.json(1 hunks)packages/html-templates/scripts/bundle-template.js(1 hunks)packages/html-templates/webpack.config.common.js(1 hunks)
💤 Files with no reviewable changes (1)
- packages/html-templates/index.js
✅ Files skipped from review due to trivial changes (1)
- packages/html-templates/.gitignore
🔇 Additional comments (2)
packages/html-templates/webpack.config.common.js (1)
12-12: Verify architectural decision regarding static dist directory.The change from a configurable
distDirto a static path might reduce flexibility. Please confirm if this is intentional as part of the migration to Rollup.Also applies to: 18-19
✅ Verification successful
Static
dist-templatedirectory is aligned with the codebase patternsThe change to a static
dist-templatedirectory appears intentional and well-structured, following the pattern of dedicated output directories across the codebase. This specific naming suggests a purposeful separation of template outputs, which aligns with the Rollup migration strategy.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if other packages use similar static dist directory pattern rg -g '*.js' -g '*.ts' "path\.join\(__dirname,\s*['\"]dist" --type-add 'js:*.{js,ts,jsx,tsx}'Length of output: 1808
packages/html-templates/package.json (1)
5-5: LGTM! Main entry point update aligns with new build output.The update to use
dist/index.jsas the main entry point correctly reflects the new build structure.
| const template = fs.readFileSync(path.join(ROOT_DIR, 'dist-template', 'index.html'), 'utf8'); | ||
| const output = `module.exports = decodeURI("${encodeURI(template)}");`; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add error handling for file operations.
The synchronous file operations could fail if the file doesn't exist or has incorrect permissions. Consider adding try-catch blocks and validation.
-const template = fs.readFileSync(path.join(ROOT_DIR, 'dist-template', 'index.html'), 'utf8');
-const output = `module.exports = decodeURI("${encodeURI(template)}");`;
+try {
+ const templatePath = path.join(ROOT_DIR, 'dist-template', 'index.html');
+ if (!fs.existsSync(templatePath)) {
+ throw new Error('Template file not found');
+ }
+ const template = fs.readFileSync(templatePath, 'utf8');
+ const output = `module.exports = decodeURI("${encodeURI(template)}");`;
+} catch (error) {
+ console.error('Failed to process template:', error);
+ process.exit(1);
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const template = fs.readFileSync(path.join(ROOT_DIR, 'dist-template', 'index.html'), 'utf8'); | |
| const output = `module.exports = decodeURI("${encodeURI(template)}");`; | |
| try { | |
| const templatePath = path.join(ROOT_DIR, 'dist-template', 'index.html'); | |
| if (!fs.existsSync(templatePath)) { | |
| throw new Error('Template file not found'); | |
| } | |
| const template = fs.readFileSync(templatePath, 'utf8'); | |
| const output = `module.exports = decodeURI("${encodeURI(template)}");`; | |
| } catch (error) { | |
| console.error('Failed to process template:', error); | |
| process.exit(1); | |
| } |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/rollup-plugin/package.json (1)
15-15: Improve build script robustnessThe build script uses
cdto navigate directories which can be fragile. Consider using workspace-relative paths instead.- "build": "npm run clean && cd ../../ && rollup -c packages/rollup-plugin/rollup.config.mjs", + "build": "npm run clean && rollup -c rollup.config.mjs",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (11)
.eslintrc.js(2 hunks)packages/html-templates/.gitignore(1 hunks)packages/html-templates/index.js(0 hunks)packages/html-templates/package.json(1 hunks)packages/html-templates/scripts/bundle-template.js(1 hunks)packages/html-templates/webpack.config.common.js(1 hunks)packages/rollup-plugin/.eslintignore(1 hunks)packages/rollup-plugin/.gitignore(1 hunks)packages/rollup-plugin/package.json(4 hunks)packages/rollup-plugin/rollup.config.mjs(1 hunks)packages/rollup-plugin/tsconfig.json(1 hunks)
💤 Files with no reviewable changes (1)
- packages/html-templates/index.js
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/html-templates/.gitignore
- packages/rollup-plugin/.eslintignore
- packages/rollup-plugin/.gitignore
- .eslintrc.js
- packages/rollup-plugin/rollup.config.mjs
- packages/rollup-plugin/tsconfig.json
- packages/html-templates/webpack.config.common.js
- packages/html-templates/scripts/bundle-template.js
- packages/html-templates/package.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: CodeQL
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/rollup-plugin/package.json (2)
5-6:⚠️ Potential issueFix inconsistent output directory paths
There's an inconsistency between the output paths:
mainpoints todist/directorytypespoints totypes/directoryThis could cause module resolution issues.
Apply this diff to align the paths:
"main": "./dist/index.js", - "types": "types/index.d.ts", + "types": "./dist/index.d.ts",Likely invalid or redundant comment.
49-52: Consider using caret ranges for Rollup pluginsUsing fixed versions for Rollup plugins can make updates harder. Consider using caret ranges to allow minor version updates.
Let's verify if newer versions are available and check for any security advisories:
Apply this diff to use caret ranges:
- "@rollup/plugin-commonjs": "28.0.2", - "@rollup/plugin-json": "6.1.0", - "@rollup/plugin-node-resolve": "16.0.0", - "@rollup/plugin-typescript": "12.1.2", + "@rollup/plugin-commonjs": "^28.0.2", + "@rollup/plugin-json": "^6.1.0", + "@rollup/plugin-node-resolve": "^16.0.0", + "@rollup/plugin-typescript": "^12.1.2",
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
packages/rollup-plugin/package.json (2)
Line range hint
19-21: Remove outdated directories configuration.The
directoriesfield still references the oldlibdirectory which is no longer used.Apply this diff to remove the outdated configuration:
- "directories": { - "lib": "lib" - },
8-14: Enhance package exports configuration.The exports field could be improved by:
- Adding a default export condition
- Ensuring consistent path format
Apply this diff to enhance the exports configuration:
"exports": { ".": { + "default": "./dist/index.mjs", "import": "./dist/index.mjs", "require": "./dist/index.cjs", - "types": "./dist/index.d.ts" + "types": "./types/index.d.ts" } },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.eslintrc.js(2 hunks)packages/rollup-plugin/.gitignore(1 hunks)packages/rollup-plugin/package.json(3 hunks)packages/rollup-plugin/rollup.config.mjs(1 hunks)packages/rollup-plugin/tsconfig.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- .eslintrc.js
- packages/rollup-plugin/.gitignore
- packages/rollup-plugin/tsconfig.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/rollup-plugin/rollup.config.mjs (2)
14-14: Verify TypeScript configuration existence.The configuration references
./tsconfig.json. Let's verify its existence and configuration.Also applies to: 25-25
✅ Verification successful
TypeScript configuration verified and valid ✅
The
tsconfig.jsonexists and contains appropriate TypeScript configuration, extending from@tsconfig/node16with proper module resolution and declaration file generation settings.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if tsconfig exists and validate its content ls -la ./packages/rollup-plugin/tsconfig.json cat ./packages/rollup-plugin/tsconfig.json | jq .Length of output: 251
Script:
#!/bin/bash # View raw content of tsconfig.json cat ./packages/rollup-plugin/tsconfig.jsonLength of output: 282
6-6: Verify TypeScript source file existence.The configuration references
./src/index.tsas the entry point. Let's verify its existence and structure.Also applies to: 17-17
✅ Verification successful
Entry point verified successfully.
The TypeScript entry point exists at the specified path and exports the required plugin functionality.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the TypeScript entry point exists and show its structure ls -la ./packages/rollup-plugin/src/index.ts ast-grep --pattern 'export $$$' ./packages/rollup-plugin/src/index.tsLength of output: 205
Script:
#!/bin/bash # Check file content and try different export patterns cat ./packages/rollup-plugin/src/index.ts # Try different export patterns echo -e "\nChecking default export:" ast-grep --pattern 'export default $$$' echo -e "\nChecking named exports:" ast-grep --pattern 'export const $$$' echo -e "\nChecking type exports:" ast-grep --pattern 'export type $$$'Length of output: 66203
| export default defineConfig([ | ||
| { | ||
| input: './src/index.ts', | ||
| output: { | ||
| dir: './dist', | ||
| format: 'esm', | ||
| entryFileNames: '[name].mjs', | ||
| chunkFileNames: 'chunks/[name].mjs', | ||
| sourcemap: true, | ||
| }, | ||
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | ||
| }, | ||
| { | ||
| input: './src/index.ts', | ||
| output: { | ||
| dir: './dist', | ||
| format: 'commonjs', | ||
| entryFileNames: '[name].cjs', | ||
| chunkFileNames: 'chunks/[name].cjs', | ||
| sourcemap: true, | ||
| }, | ||
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider adding essential Rollup configuration options.
The configuration could benefit from additional options to improve the build output:
- Add
preserveModules: truefor better tree-shaking support - Configure
externalto exclude dependencies from the bundle
Apply this diff to enhance the configuration:
export default defineConfig([
{
input: './src/index.ts',
+ external: [/node_modules/],
output: {
dir: './dist',
format: 'esm',
entryFileNames: '[name].mjs',
chunkFileNames: 'chunks/[name].mjs',
sourcemap: true,
+ preserveModules: true,
},
plugins: [typescript({ tsconfig: './tsconfig.json' })],
},
{
input: './src/index.ts',
+ external: [/node_modules/],
output: {
dir: './dist',
format: 'commonjs',
entryFileNames: '[name].cjs',
chunkFileNames: 'chunks/[name].cjs',
sourcemap: true,
+ preserveModules: true,
},
plugins: [typescript({ tsconfig: './tsconfig.json' })],
},
]);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export default defineConfig([ | |
| { | |
| input: './src/index.ts', | |
| output: { | |
| dir: './dist', | |
| format: 'esm', | |
| entryFileNames: '[name].mjs', | |
| chunkFileNames: 'chunks/[name].mjs', | |
| sourcemap: true, | |
| }, | |
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | |
| }, | |
| { | |
| input: './src/index.ts', | |
| output: { | |
| dir: './dist', | |
| format: 'commonjs', | |
| entryFileNames: '[name].cjs', | |
| chunkFileNames: 'chunks/[name].cjs', | |
| sourcemap: true, | |
| }, | |
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | |
| }, | |
| ]); | |
| export default defineConfig([ | |
| { | |
| input: './src/index.ts', | |
| external: [/node_modules/], | |
| output: { | |
| dir: './dist', | |
| format: 'esm', | |
| entryFileNames: '[name].mjs', | |
| chunkFileNames: 'chunks/[name].mjs', | |
| sourcemap: true, | |
| preserveModules: true, | |
| }, | |
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | |
| }, | |
| { | |
| input: './src/index.ts', | |
| external: [/node_modules/], | |
| output: { | |
| dir: './dist', | |
| format: 'commonjs', | |
| entryFileNames: '[name].cjs', | |
| chunkFileNames: 'chunks/[name].cjs', | |
| sourcemap: true, | |
| preserveModules: true, | |
| }, | |
| plugins: [typescript({ tsconfig: './tsconfig.json' })], | |
| }, | |
| ]); |
| @@ -2,8 +2,16 @@ | |||
| "name": "rollup-plugin-bundle-stats", | |||
| "version": "4.18.0", | |||
| "description": "In-depth bundle analyzer for rollup(bundle size, assets, modules, packages)", | |||
| "main": "lib/index.js", | |||
| "main": "./dist/index.cjs", | |||
| "module": "./dist/index.mjs", | |||
| "types": "types/index.d.ts", | |||
There was a problem hiding this comment.
💡 Codebase verification
Update types field to match TypeScript output directory
The types field in package.json points to types/index.d.ts, but TypeScript is configured to output declaration files to dist/ directory (declarationDir: "./dist" in tsconfig.json). Update the types field to "dist/index.d.ts" to match the TypeScript configuration and the exports field.
🔗 Analysis chain
Verify TypeScript declaration file output location.
The types field points to types/index.d.ts but exports use ./dist/index.d.ts. Let's verify the TypeScript configuration to ensure declaration files are output to the correct location.
Also applies to: 12-12
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check TypeScript configuration for declaration output
cat ./packages/rollup-plugin/tsconfig.json | jq '.compilerOptions.declarationDir'
Length of output: 146
Script:
#!/bin/bash
# Check if tsconfig exists and view its contents
echo "=== Checking tsconfig.json existence and contents ==="
fd tsconfig.json packages/rollup-plugin/ --type f --exec cat {}
echo -e "\n=== Checking for .d.ts files ==="
fd "\.d\.ts$" packages/rollup-plugin/
echo -e "\n=== Viewing package.json exports field ==="
cat packages/rollup-plugin/package.json | grep -A 10 '"exports":'
Length of output: 923
Summary by CodeRabbit
Release Notes
Build Configuration
Package Management
Development
.gitignoreto track library directories and exclude the distribution folder.