-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RecordingUri
component
#8210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🔩 data model
dataplatform
Rerun Data Platform integration
exclude from changelog
PRs with this won't show up in CHANGELOG.md
ui
concerns graphical user interface
labels
Nov 22, 2024
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
screenshot? :) |
jleibs
approved these changes
Nov 25, 2024
zehiko
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔩 data model
dataplatform
Rerun Data Platform integration
exclude from changelog
PRs with this won't show up in CHANGELOG.md
ui
concerns graphical user interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces a new
RecordingUri
component (which contains just a string) and assorted UI, which present the URI as a link that opens said component. Also introduce a newFileSource::Uri
to account for this new way of opening recordings.Note: displaying links is disabled in wasm build, because
DataSource::from_uri()
is not available there. I'm actually not quite sure what the story is to load remote recordings from the web viewer 🤷🏻