Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RecordingUri component #8210

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Introduce RecordingUri component #8210

merged 7 commits into from
Nov 26, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 22, 2024

What

This PR introduces a new RecordingUri component (which contains just a string) and assorted UI, which present the URI as a link that opens said component. Also introduce a new FileSource::Uri to account for this new way of opening recordings.

Note: displaying links is disabled in wasm build, because DataSource::from_uri() is not available there. I'm actually not quite sure what the story is to load remote recordings from the web viewer 🤷🏻

image

@abey79 abey79 added 🔩 data model dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface labels Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
5c53182 https://rerun.io/viewer/pr/8210

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Nov 22, 2024

Latest documentation preview deployed successfully.

Result Commit Link
5c53182 https://landing-dy33wq5dl-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member

Wumpf commented Nov 25, 2024

screenshot? :)

@abey79 abey79 merged commit 10c1f5c into main Nov 26, 2024
36 of 37 checks passed
@abey79 abey79 deleted the antoine/recording-uri branch November 26, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants