Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: updated partial APIs naming #8826

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Python: updated partial APIs naming #8826

merged 2 commits into from
Jan 28, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 27, 2025

  • update_fields(clear: bool, ...) -> from_fields(clear_unset: bool, ...)
  • clear_fields() -> cleared()
  • cleared() is not implemented by forwarding to from_fields(clear_unset=True)

This does not cover implementing the constructors in terms of from_fields(). If that happens at all, this will be in one or more follow-ups.


@teh-cmc teh-cmc added 🐍 Python API Python logging API do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8826 | +nightly +main |

Note: This comment is updated whenever you push a commit.

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 27, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12990906153

@teh-cmc teh-cmc force-pushed the cmc/python_renaming branch from b6e0608 to 96559d7 Compare January 27, 2025 14:42
@abey79 abey79 self-requested a review January 28, 2025 08:12
Base automatically changed from cmc/python_columnar_cleanup to main January 28, 2025 11:08
@teh-cmc teh-cmc force-pushed the cmc/python_renaming branch from 96559d7 to 737dde3 Compare January 28, 2025 11:10
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 28, 2025
@teh-cmc teh-cmc merged commit c8d00f2 into main Jan 28, 2025
28 of 30 checks passed
@teh-cmc teh-cmc deleted the cmc/python_renaming branch January 28, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants