Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ columns method for convenient send_columns call through archetypes #8828

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 27, 2025

Related

What

C++ point send_columns example is now a lot shorter:

    // Partition our data as expected across the 5 timesteps.
    auto position =
        rerun::Points3D::update_fields().with_positions(positions).columns({2, 4, 4, 3, 4});
    auto color_and_radius =
        rerun::Points3D::update_fields().with_colors(colors).with_radii(radii).columns();

    rec.send_columns2("points", time_column, position, color_and_radius);

Left todo among other things:

  • update all other examples
    • we'll likely need the with_many calls we introduced in Rust as well
  • send_columns2 should become send_columns
    • this will be a breaking change -> add migration guide

@Wumpf Wumpf force-pushed the andreas/cpp/archetype-send-columns branch from 4ba6f87 to cbea05e Compare January 27, 2025 15:07
Copy link

github-actions bot commented Jan 27, 2025

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8828 | +nightly +main |

Note: This comment is updated whenever you push a commit.

rerun_cpp/src/rerun/recording_stream.hpp Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit a2a0079 into main Jan 28, 2025
24 of 26 checks passed
@Wumpf Wumpf deleted the andreas/cpp/archetype-send-columns branch January 28, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants