Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain and test the hashing behavior relied upon in the micro-batcher #8831

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 27, 2025

@teh-cmc teh-cmc added 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model 🪵 Log & send APIs Affects the user-facing API for all languages labels Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
b5bbc82 https://rerun.io/viewer/pr/8831 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 28, 2025

I'm not sensing any objection, and the number in the PR tab is making me very uncomfortable right now 💀 (also who doesn't want more docs and tests 🙃)

@teh-cmc teh-cmc merged commit 24a233f into main Jan 28, 2025
31 checks passed
@teh-cmc teh-cmc deleted the cmc/embrace_the_hash_or_lack_thereof branch January 28, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant