The empty/full entity icon now reflects presence of component on the current timeline #8839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
According to the code, the entity icon was supposed to reflect the existence of data on the current timeline. However, due to a bug in
all_components_on_timline
, it reflected the existence of data on any timeline.This PR fixes the aforementioned bug. As a result, the icon now actually represents the state on current timeline. Some snapshot tests had to be fixed to pass.
Reminder: As soon as a static component is logged to an entity, it is deemed to have data on all past, present, and future timelines. As a result, it always has the "full" icon.