Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The empty/full entity icon now reflects presence of component on the current timeline #8839

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 28, 2025

What

According to the code, the entity icon was supposed to reflect the existence of data on the current timeline. However, due to a bug in all_components_on_timline, it reflected the existence of data on any timeline.

This PR fixes the aforementioned bug. As a result, the icon now actually represents the state on current timeline. Some snapshot tests had to be fixed to pass.

Reminder: As soon as a static component is logged to an entity, it is deemed to have data on all past, present, and future timelines. As a result, it always has the "full" icon.

Copy link

github-actions bot commented Jan 28, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9a81742 https://rerun.io/viewer/pr/8839 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 force-pushed the antoine/bug-all-componants-on-timeline branch from 755284d to f324228 Compare January 28, 2025 10:12
@abey79 abey79 changed the title Bug with all_components_on_timeline? The empty/full entity icon now reflects presence of component on the current timeline Jan 28, 2025
@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 28, 2025
@abey79 abey79 marked this pull request as ready for review January 28, 2025 12:19
@teh-cmc teh-cmc self-requested a review January 28, 2025 13:12
@teh-cmc teh-cmc merged commit 8e1e5d9 into main Jan 28, 2025
31 checks passed
@teh-cmc teh-cmc deleted the antoine/bug-all-componants-on-timeline branch January 28, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants