Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order-agnostic rrd compare command + snippet clean up #8843

Merged
merged 12 commits into from
Jan 29, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 28, 2025

See:

/// If specified, the comparison will focus purely on semantics, ignoring order.
///
/// The Rerun data model is itself unordered, and because many of the internal pipelines are
/// asynchronous by nature, it is very easy to end up with semantically identical, but
/// differently ordered data.
/// In most cases, the distinction is irrelevant, and you'd rather the comparison succeeds.
#[clap(long, default_value_t = false)]
unordered: bool,

@teh-cmc teh-cmc added enhancement New feature or request 🔨 testing testing and benchmarks do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Web viewer failed to build.

Result Commit Link Manifest
https://rerun.io/viewer/pr/8843 +nightly +main

Note: This comment is updated whenever you push a commit.

Base automatically changed from cmc/zero_length_indicators_cpp to main January 29, 2025 11:12
@teh-cmc teh-cmc force-pushed the cmc/snippets_toml_cleanup branch from 0d7f9b8 to a1f57ed Compare January 29, 2025 11:17
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 29, 2025
@teh-cmc teh-cmc merged commit 9ff9e7f into main Jan 29, 2025
26 of 31 checks passed
@teh-cmc teh-cmc deleted the cmc/snippets_toml_cleanup branch January 29, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant