Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out of {platform/compiler}-dependent C++ snippets #8851

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 29, 2025

Title

@teh-cmc teh-cmc changed the title C++? Fix {platform/compiler}-dependent C++ snippet issue (maybe?) Jan 29, 2025
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very reasonable guess imho

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 29, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13032196476

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 29, 2025

Somehow that's not it... why does this work locally... I'll have to opt-out C++ then.

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 29, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Jan 29, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
879251d https://rerun.io/viewer/pr/8851 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13033132103

@teh-cmc teh-cmc changed the title Fix {platform/compiler}-dependent C++ snippet issue (maybe?) Opt out of {platform/compiler}-dependent C++ snippets Jan 29, 2025
@teh-cmc teh-cmc marked this pull request as ready for review January 29, 2025 14:58
@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 29, 2025

I'm so sad

@teh-cmc teh-cmc added 🔨 testing testing and benchmarks 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jan 29, 2025
@teh-cmc teh-cmc merged commit 46bca88 into main Jan 29, 2025
74 of 82 checks passed
@teh-cmc teh-cmc deleted the cmc/c_plus_plus_lol branch January 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants