Make it possible to change the contents of a view multiple times per frame #8854
+84
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🪳 bug
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
approved these changes
Jan 30, 2025
Comment on lines
+48
to
+53
| entity_path_filter: ResolvedEntityPathFilter, | ||
|
|
||
| /// Update entity path filter. | ||
| /// | ||
| /// Mutations go to this value and should be saved to the blueprint store when they occur. | ||
| new_entity_path_filter: Arc<Mutex<ResolvedEntityPathFilter>>, |
There was a problem hiding this comment.
This is such a common pattern in imgui. We should at some point think of coming up with a higher-level abstraction for it 🤔 (but not now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Before, when we would mutate a view entity path filter multiple time in a frame, only the last mutation would be recorded. This could be visible by:
==> only one entity would be removed.
This PR makes it possible to mutate a view's content multiple time per frame, solving this bug—and possibly others.