Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest egui #8865

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Update to latest egui #8865

merged 4 commits into from
Jan 30, 2025
+137 −109

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 30, 2025 •
edited
Loading

Changes

  • When painting a rect stroke, you must chose if the stroke is inside, outside, or on the rectangle.
  • TextEdit and ColorButton have been shrunk to fit inside their widget rects

TODO

  • Check that the choices of StrokeKind makes sense everywhere

@emilk emilk added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work labels Jan 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 063f97e https://rerun.io/viewer/pr/8865 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk force-pushed the emilk/update-egui-lalala branch from 145c7ab to cc1e687 Compare January 30, 2025 10:13
@emilk emilk marked this pull request as ready for review January 30, 2025 10:26
abey79
abey79 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did some cursory testing, didn't spot anything super weird.

@emilk
Merge branch 'main' into emilk/update-egui-lalala
063f97e 
# Conflicts:
#	crates/viewer/re_time_panel/src/lib.rs
#	crates/viewer/re_time_panel/tests/snapshots/time_panel_filter_test_active_query.png
@emilk emilk merged commit a061683 into main Jan 30, 2025
31 checks passed
@emilk emilk deleted the emilk/update-egui-lalala branch January 30, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @abey79