Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated extensions for future removal #1429

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Deprecated extensions for future removal #1429

merged 2 commits into from
Oct 30, 2024

Conversation

jlouvel
Copy link
Member

@jlouvel jlouvel commented Oct 28, 2024

Deprecated GAE, GWT, OSGi and RDF extensions for removal in next major release.

The aim

Indicate code that will be removed in next major version.

The solution

Added deprecation annotations.

Check-list

  • PR size
    • Under 300 lines ✅
    • Can't be split without complicating the process even more
  • Tests
    • Added
    • Not applicable (why?)
  • Doc
    • Added
    • Not applicable
  • Reviewer
    • Asked for a review
    • Added label DO NOT REVIEW

Deprecated GAE, GWT, OSGi and RDF extensions for removal in next major release.
@jlouvel jlouvel requested a review from thboileau October 28, 2024 04:25
@jlouvel
Copy link
Member Author

jlouvel commented Oct 29, 2024

@thboileau Let's discuss the GWT extension, we might want to reverse its deprecation, keep this extension and the GWT edition overall for version 2.6 as a way to provide long term support which should work with GWT 2.11.0 and above.

Copy link
Contributor

@thboileau thboileau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlouvel jlouvel merged commit 6e9c8cc into 2.5 Oct 30, 2024
1 check passed
@jlouvel jlouvel deleted the 2.5-deprecations branch October 30, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants