Add possibility to configure Run with entire Downloader, ItemPipeline and Processor instances #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to create re-usable configurations for Downloader, ItemPipeline and Processor objects.
I use roach with Symfony bundle https://github.com/Ne-Lexa/roach-php-bundle and now I have to duplicate pipeline and middleware configurations for different spiders in my application. I think, that my proposal can avoid duplicating this:
and allows this:
To avoid BC-break I have extended Run fields and add a possibility to configure the Engine both with an array of middlewares/processors and an entire instances of Downloader/ItemPipeline/Processor.