Option to pass a bucket size for the httpRequestsDuration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocklan
requested changes
Nov 4, 2020
There was a problem hiding this comment.
Hi @gustavomassa ! Thanks very much for the pull request. I like the general approach and it looks good. I've added a few comments in the PR for you to consider.
| /// | ||
| /// </summary> | ||
| /// <param name="bucektSize"></param> | ||
| public PrometheusHttpRequestModule(double[] bucektSize) |
There was a problem hiding this comment.
If you change this constructor so that it looks like this:
public PrometheusHttpRequestModule(double[] bucektSize = null)
Does that mean you don't need the other constructor at all?
There was a problem hiding this comment.
(Also, please fix the spelling mistake :)
| /// </summary> | ||
| /// <param name="sender"></param> | ||
| /// <param name="e"></param> | ||
| // Record the time of the begin request event. | ||
| public void OnBeginRequest(Object sender, EventArgs e) | ||
| private void OnBeginRequest(Object sender, EventArgs e) |
There was a problem hiding this comment.
Any reason to change this to private?
|
@gustavomassa if you could reply to this PR within a week that would be great, if not I'll close it as abandoned. |
BEH-1731 Atualizando as packages
* refact: Apps Atualizados para o modelo de PackageReference * chore: Upgrade do dotnet framework para 4.8 * chore: Upgrade de dependências * chore: AssemblyInfo * feat: package reference format * fix: ajustada versão para 1.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to increase the bucket size of the httpRequestsDuration, 10 seconds was not enough, so we used constructors for it. Please let me know if you have a better option.