fixed few issues with update_attributes method #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update_attributes doesn't work for 1) not valid records 2) white listed att_accessible attributes
|
Not clear to me why you would want to save invalid records, or to soft-destroy an invalid record. |
|
Sometimes it is possible to have conditional validation. Example on registration first,last names are optional but mandatory in edit profile. So it is really possible to have invalid records saved in db. Any reason not do delete invalid records. On 29 Nov 2011, at 18:53, Michael [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_attributes doesn't work for